cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tony-- <>
Subject [GitHub] cordova-lib pull request: fix CB-9145 prepare can lose data during...
Date Tue, 09 Jun 2015 17:44:06 GMT
GitHub user tony-- opened a pull request:

    fix CB-9145 prepare can lose data during config munge

    I added a test that adds access tags as described in CB-9145.  This test fails when run
against master.
    This is because the current exact match detection assumes that the query returning a result
is sufficient to identify an exact attribute match.  However, the query may also return results
with additional attributes and these should be excluded.  
    Originally I added a utility function that handles this case by performing a 2-way comparison.
 However, we already know that foundChild.attr matches srcChild.attr because foundChild is
a query result.  We only need to determine if foundChild has extra attributes, so simply comparing
the number of attributes is sufficient.  
    After making this change, all tests are green - including the newly added test that fails
against master.

You can merge this pull request into a Git repository by running:

    $ git pull CB-9145

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #242
commit 25982317b26c831dbea9d6b71dd57a90b933fc68
Author: Tony Homer <>
Date:   2015-06-09T17:05:10Z

    fix CB-9145 prepare can lose data during config munge


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message