cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nikhil Khandelwal <nikhi...@microsoft.com>
Subject RE: [iOS] cordova-ios 4.0.x branch merge to master
Date Thu, 25 Jun 2015 16:16:16 GMT
Thanks, Shaz for fixing the compile failures quickly! 

I remember you were doing some automated impact assessment on the plugin ecosystem with the
following API changes:
https://github.com/apache/cordova-ios/blob/master/guides/API%20changes%20in%204.0.md

Are there results to share?

Thanks,
Nikhil


-----Original Message-----
From: Shazron [mailto:shazron@gmail.com] 
Sent: Thursday, June 25, 2015 7:07 AM
To: dev@cordova.apache.org
Subject: Re: [iOS] cordova-ios 4.0.x branch merge to master

Buildbot still failing because it needs to update ios-sim to 4.x

On Thu, Jun 25, 2015 at 6:11 AM, Shazron <shazron@gmail.com> wrote:

> Fixed: https://issues.apache.org/jira/browse/CB-9247
>
> On Wed, Jun 24, 2015 at 6:42 PM, Shazron <shazron@gmail.com> wrote:
>
>> The whitelist property was removed:
>> https://github.com/apache/cordova-ios/blob/master/guides/API%20change
>> s%20in%204.0.md
>>
>> On Wed, Jun 24, 2015 at 6:41 PM, Shazron <shazron@gmail.com> wrote:
>>
>>> The whitelist plugin itself is fine, it's the plugin's tests that 
>>> are
>>> failing:
>>>
>>> https://github.com/apache/cordova-mobile-spec/blob/1f1b08f2a7dbea55f
>>> 68c560404b94efaa2108d0c/cordova-plugin-whitelist/src/ios/CDVWhitelis
>>> tAPI.m#L41
>>>
>>> On Wed, Jun 24, 2015 at 6:38 PM, Shazron <shazron@gmail.com> wrote:
>>>
>>>> Ah I see it's a whitelist plugin thing, strange -- when I used it 
>>>> last in 4.0.x it was fine:
>>>> /Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/mobilespec/Plugins/org.apache.cordova.test.whitelist/CDVWhitelistAPI.m:41:73:
>>>> error: no visible @interface for 'CDVViewController' declares the 
>>>> selector 'whitelist'
>>>>     CDVWhitelist* whitelist = [(CDVViewController 
>>>> *)self.viewController whitelist];
>>>>                                
>>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>> ^~~~~~~~~
>>>>
>>>> I'll fix it later tonight, gtg.
>>>>
>>>>
>>>> On Wed, Jun 24, 2015 at 6:35 PM, Shazron <shazron@gmail.com> wrote:
>>>>
>>>>> Not sure.. I did the "npm test" platform tests and they were fine.
>>>>>
>>>>> On Wed, Jun 24, 2015 at 6:23 PM, Dmitry Blotsky < 
>>>>> dblotsky@microsoft.com> wrote:
>>>>>
>>>>>> The latest build of iOS failed:
>>>>>> http://ci.apache.org/builders/cordova-ios/builds/1150. Output here:
>>>>>> http://ci.apache.org/builders/cordova-ios/builds/1150/steps/running-tests/logs/stdio.
>>>>>> Sorry, I don't have the context to investigate: is it something 
>>>>>> related to this change?
>>>>>>
>>>>>> Kindly,
>>>>>> Dmitry
>>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Shazron [mailto:shazron@gmail.com]
>>>>>> Sent: Wednesday, June 24, 2015 5:59 PM
>>>>>> To: dev@cordova.apache.org
>>>>>> Subject: Re: [iOS] cordova-ios 4.0.x branch merge to master
>>>>>>
>>>>>> after a test merge, all platform tests pass (using "npm test"), 
>>>>>> so I'll be doing the actual merge (forgive the commits@ email 
>>>>>> barrage)
>>>>>>
>>>>>> On Wed, Jun 24, 2015 at 4:45 PM, Shazron <shazron@gmail.com>
wrote:
>>>>>>
>>>>>> > Also, with cordova-ios 4.x, ios-sim 4.x and iso-deploy 2.x 
>>>>>> > release (which again, I'm the only maintainer :)
>>>>>> >
>>>>>> >
>>>>>> https://shazronatadobe.wordpress.com/2015/05/18/ios-deploy-and-io
>>>>>> s-sim
>>>>>> > -roadmaps/
>>>>>> >
>>>>>> >
>>>>>> >
>>>>>> > On Wed, Jun 24, 2015 at 4:42 PM, Shazron <shazron@gmail.com>
wrote:
>>>>>> >
>>>>>> >> The main thing is pluggable webview support in the platform,
i.e.
>>>>>> >> WKWebView. Don't have time to write this up (since, I like
to
>>>>>> remind
>>>>>> >> people, I work on this alone, hint hint). I'll write it
up 
>>>>>> >> once I
>>>>>> get
>>>>>> >> the merge going.
>>>>>> >>
>>>>>> >> On Wed, Jun 24, 2015 at 4:36 PM, Nikhil Khandelwal <

>>>>>> >> nikhilkh@microsoft.com> wrote:
>>>>>> >>
>>>>>> >>> I would love to see a high level summary of what's in
the 
>>>>>> >>> 4.0.x
>>>>>> branch?
>>>>>> >>> I have not been closely keeping tab of this branch.
We'll 
>>>>>> >>> need to prepare such a summary anyway - when blogging
and 
>>>>>> >>> doing a release notes about it anyway.
>>>>>> >>>
>>>>>> >>> Thanks,
>>>>>> >>> Nikhil
>>>>>> >>>
>>>>>> >>>
>>>>>> >>> -----Original Message-----
>>>>>> >>> From: tommy-carlos williams [mailto:tommy@devgeeks.org]
>>>>>> >>> Sent: Thursday, June 18, 2015 4:22 PM
>>>>>> >>> To: dev@cordova.apache.org
>>>>>> >>> Subject: Re: [iOS] cordova-ios 4.0.x branch merge to
master
>>>>>> >>>
>>>>>> >>> Agreed
>>>>>> >>>
>>>>>> >>> --
>>>>>> >>> tommy-carlos williams
>>>>>> >>>
>>>>>> >>> On 19 June 2015 at 08:53:24, Steven Gill 
>>>>>> >>> (stevengill97@gmail.com)
>>>>>> wrote:
>>>>>> >>>
>>>>>> >>> Do it!
>>>>>> >>>
>>>>>> >>> On Thu, Jun 18, 2015 at 3:29 PM, Shazron <shazron@gmail.com>
>>>>>> wrote:
>>>>>> >>>
>>>>>> >>> > I intend to merge the cordova-ios 4.0.x branch
to master.
>>>>>> >>> >
>>>>>> >>> > Most of the remaining issues in
>>>>>> >>> >
>>>>>> https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=7
>>>>>> 6
>>>>>> >>> > are related to the CLI or the wkwebview-engine
plugin, not 
>>>>>> >>> > platform
>>>>>> >>> issues.
>>>>>> >>> >
>>>>>> >>> > I'll resolve any outstanding PRs first.
>>>>>> >>> >
>>>>>> >>> > I still intend to implement Workspaces since I
think that's 
>>>>>> >>> > important for 4.0.x and will do that in another
branch.
>>>>>> >>> >
>>>>>> >>> > Thoughts?
>>>>>> >>> >
>>>>>> >>>
>>>>>> >>
>>>>>> >>
>>>>>> >
>>>>>>
>>>>>> -----------------------------------------------------------------
>>>>>> ---- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>>>>>> For additional commands, e-mail: dev-help@cordova.apache.org
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>
Mime
View raw message