cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request: CB-9237 Add cdvfile:// support ...
Date Mon, 29 Jun 2015 18:58:12 GMT
Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media/pull/57#discussion_r33498946
  
    --- Diff: src/windows/MediaProxy.js ---
    @@ -35,6 +46,8 @@ module.exports = {
             var src = args[1];
             var thisM = Media.get(id);
     
    +        src = cdvfileToNative(src);
    --- End diff --
    
    Yes, thanks!
    Although I think of moving this commit to [CB-9238 Media plugin cannot record audio on
windows](https://github.com/apache/cordova-plugin-media/pull/58) PR as it requires paths handling
introduced there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message