cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <>
Subject [GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...
Date Mon, 29 Jun 2015 16:13:44 GMT
Github user robpaveza commented on a diff in the pull request:
    --- Diff: src/windows/MediaProxy.js ---
    @@ -33,8 +42,11 @@ module.exports = {
         create:function(win, lose, args) {
             var id = args[0];
             var src = args[1];
    +        var createAudioNode = args[2];
    --- End diff --
    This is later compared to true using ===.  Suggest coercing it to true or false here,
"var createAudioNode = !!args[2];".

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message