cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...
Date Mon, 29 Jun 2015 16:12:21 GMT
Github user robpaveza commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33480928
  
    --- Diff: src/windows/MediaProxy.js ---
    @@ -33,8 +42,11 @@ module.exports = {
         create:function(win, lose, args) {
             var id = args[0];
             var src = args[1];
    +        var createAudioNode = args[2];
             var thisM = Media.get(id);
     
    +        src = setTemporaryFsByDefault(src);
    --- End diff --
    
    Would prefer this line immediately follow "var src = args[1]" because it is easy to miss
this mutation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message