cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <>
Subject [GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...
Date Mon, 29 Jun 2015 16:11:30 GMT
Github user robpaveza commented on a diff in the pull request:
    --- Diff: src/windows/MediaProxy.js ---
    @@ -26,6 +26,15 @@ var MediaError = require('cordova-plugin-media.MediaError');
     var recordedFile;
    +function setTemporaryFsByDefault(src) {
    +    if (!/.+:/.test(src)) {
    --- End diff --
    This test seems like it could collide with absolute file paths (e.g., "c:\") or
UNC paths (e.g., "\\?\C:\").  Are you sure this is adequate?  I'm curious about whether
creating a new Windows.Foundation.Uri would be more likely to detect such sources.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message