cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9122 Added tests for platform/plugin ...
Date Fri, 26 Jun 2015 09:15:26 GMT
Github user alsorokin commented on the pull request:

    https://github.com/apache/cordova-lib/pull/246#issuecomment-115596356
  
    - Disabling console logging seems to be really tricky in this case.Most of it comes from
android platform code which runs in child_process.spawn.
    i've tried wrapping it and always pass stdout: 'ignore' option to it, but it seem to break
some functionality so I decided to leave it as is.
    - the underscore library which is included to cordova-lib doesn't have the module for
string processing, so it doesn't have 'endsWith' function. I've just added a clarifying comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message