cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omefire <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9122 Added tests for platform/plugin ...
Date Thu, 25 Jun 2015 19:13:03 GMT
Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/246#discussion_r33293439
  
    --- Diff: cordova-lib/spec-cordova/helpers.js ---
    @@ -17,12 +17,23 @@
         under the License.
     */
     
    -var path = require('path'),
    -    fs = require('fs'),
    -    shell = require('shelljs'),
    -    os = require('os');
    +var path         = require('path'),
    +    fs           = require('fs'),
    +    shell        = require('shelljs'),
    +    os           = require('os'),
    +    ConfigParser = require('../src/configparser/ConfigParser');
     
    -module.exports.tmpDir = function(subdir) {
    +// Just use Android everywhere; we're mocking out any calls to the `android` binary.
    +module.exports.testPlatform = 'android';
    +
    +function getConfigPath(dir) {
    +    if (dir.indexOf('config.xml') !== dir.length - 10) {
    --- End diff --
    
    @purplecabbage, I was leaning towards a comment at first, but then I realized we already
have underscore which provides this functionality. I think we should just use it and I don't
find it to be overkill.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message