cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpolivy <>
Subject [GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Date Sat, 20 Jun 2015 00:11:08 GMT
Github user dpolivy commented on a diff in the pull request:
    --- Diff: src/android/ ---
    @@ -124,16 +127,9 @@ public boolean execute(String action, JSONArray args, CallbackContext
                 this.mediaType = PICTURE;
                 this.mQuality = 80;
    --- End diff --
    I would get rid of all of these defaults here. I like your use of `optInt`, and passing
in defaults; would suggest just eliminating the forced defaults above and go with the single
line initialization in the method.
    FWIW, here's how I ported this to my local copy:
            if (action.equals("takePicture")) {
                int srcType = args.optInt(2, CAMERA);
                int destType = args.optInt(1, FILE_URI);
                // Process the rest of the configuration arguments

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message