cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpolivy <>
Subject [GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Date Sat, 20 Jun 2015 00:07:26 GMT
Github user dpolivy commented on a diff in the pull request:
    --- Diff: ---
    @@ -456,3 +457,36 @@ after calling `camera.getPicture`. Applies only when the value of
         function onFail(message) {
             alert('Failed because: ' + message);
    +call this method in onDeviceReady to see if there is a result present from a previous
call to getPicture.
    +add the same options you used when calling getPicture, or leave it out to pass default
    + successCallback, errorCallback, options );
    --- End diff --
    Minor: the `getPicture` examples in the README use `onSuccess` and `onFail` as names for
the parameters. And no spacing after parens.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message