cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...
Date Thu, 18 Jun 2015 18:07:11 GMT
Github user purplecabbage commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/146#discussion_r32759726
  
    --- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
    @@ -374,7 +374,7 @@
     			);
     			runOnlyForDeploymentPostprocessing = 0;
     			shellPath = /bin/sh;
    -			shellScript = "cordova/lib/copy-www-build-step.sh";
    +			shellScript = "node cordova/lib/copy-www-build-step.js";
    --- End diff --
    
    +1 The cli dependent on node, so it makes sense to require it in the path.
    Does this affect users who are not using the cli? Probably still not a big deal either
way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message