cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From syndbg <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...
Date Wed, 17 Jun 2015 22:51:03 GMT
Github user syndbg commented on the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112974072
  
    @purplecabbage Good catch. In the JIRA ticket, unfortunately I've pasted the wrong option
parameter, `location`, when in fact I meant `zoom`.
    
    This PR fixes `zoom=true` or `zoom=false` not making a difference in the android app.
    
    Can we agree on the fact that fixing (in my opinion) non-formatted code, even in the iOS
section of the plugin, should not be a blocker to merge this PR.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message