cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...
Date Tue, 16 Jun 2015 17:34:54 GMT
Github user shazron commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/146#discussion_r32547846
  
    --- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
    @@ -374,7 +374,7 @@
     			);
     			runOnlyForDeploymentPostprocessing = 0;
     			shellPath = /bin/sh;
    -			shellScript = "cordova/lib/copy-www-build-step.sh";
    +			shellScript = "node cordova/lib/copy-www-build-step.js";
    --- End diff --
    
    I thought about this earlier when the PR came in and I think its a good assumption since
it's a Cordova project and the user is using the CLI. The scenario where a user would take
the project from platforms/ios and run it stand-alone is miniscule. 
    
    Not sure if this is supported fully but Xcode.app does include node.js under `/Applications/Xcode.app/Contents/Developer/usr/share/xcs/Node/bin/node`
    
    You would dynamically get this path by using `xcode-select --print-path` then appending
`/usr/share/xcs/Node/bin/node`
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message