cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9114: Log deprecation message when --...
Date Tue, 16 Jun 2015 01:07:20 GMT
Github user TimBarham commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/234#discussion_r32483383
  
    --- Diff: cordova-lib/src/cordova/platform.js ---
    @@ -68,6 +68,13 @@ function addHelper(cmd, hooksRunner, projectRoot, targets, opts) {
             }
         }
     
    +    if (opts.usegit) {
    +        msg = '\r\nWARNING: The --usegit flag has been deprecated ! \r\n' +
    +              'instead, please use: `cordova platform add git-url#custom-branch`. \r\n'
+
    +              'e.g: cordova platform add https://github.com/apache/cordova-android.git#2.4.0
\r\n';
    +        events.emit('log', msg);
    --- End diff --
    
    Some nits:
    * Use `\n`, not `\r\n`.
    * Use `\'` rather than backtick (`` ` ``).
    * Use `events.emit('warning'...)`
    * No space before `!` (or even just a period - no need to get too excited :smile:).
    * Capital `I` for `Instead`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message