cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omefire <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9122 Added tests for platform/plugin ...
Date Thu, 11 Jun 2015 22:27:09 GMT
Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/246#discussion_r32275358
  
    --- Diff: cordova-lib/spec-cordova/helpers.js ---
    @@ -43,17 +54,101 @@ if (host.match(/win/)) {
     }
     */
     
    -// Just use Android everywhere; we're mocking out any calls to the `android` binary.
    -module.exports.testPlatform = 'android';
    +module.exports.setEngineSpec = function (appPath, spec) {
    +    appPath = getConfigPath(appPath);
    +    var parser = new ConfigParser(appPath);
    +
    +    parser.removeEngine(module.exports.testPlatform);
    +    parser.addEngine(module.exports.testPlatform, spec);
    +    parser.write();
    +};
    +
    +module.exports.getEngineSpec = function (appPath) {
    --- End diff --
    
    consider making this function more general by allowing the engine to be passed in as a
separate parameter, instead of using the global variable module.exports.testPlatform.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message