cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omefire <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-9147 Adding a platform via caret vers...
Date Wed, 10 Jun 2015 05:19:52 GMT
Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/244#discussion_r32088895
  
    --- Diff: cordova-lib/src/cordova/plugin.js ---
    @@ -360,6 +360,12 @@ function getPluginVariables(variables){
     
     function getVersionFromConfigFile(plugin, cfg){
         var pluginEntry = cfg.getPlugin(plugin);
    +    if (!pluginEntry) {
    +        var oldStylePluginId = pluginMapper[plugin];
    +        if (oldStylePluginId) {
    --- End diff --
    
    'oldStylePluginId' is not the correct name for what the registry-mapper (pluginMapper)
returns. it returns the package name, which is the new way of doing things. so, I'd call it
something like 'packageName' ..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message