cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-9119 Fixing intermittent 'adb ins...
Date Tue, 09 Jun 2015 01:19:23 GMT
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/180#discussion_r31976074
  
    --- Diff: bin/templates/cordova/lib/retry.js ---
    @@ -0,0 +1,63 @@
    +#!/usr/bin/env node
    +
    +/*
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +      http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +*/
    +
    +/* jshint node: true */
    +
    +"use strict";
    +
    +/*
    + * Retry a promise-returning function attemts_left times, propagating its
    + * results on success or throwing its error on a failed final attempt.
    + *
    + * Takes a number of attempts, a promise-returning function, and all its
    + * arguments (as trailing arguments).
    + */
    +module.exports.retryPromise = function (attemts_left, promiseFunction) {
    --- End diff --
    
    Consider writing unit tests for this one as it is fairly easy and isolated to write for
this function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message