cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kamrik <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: Implementation for Unified platform API
Date Fri, 05 Jun 2015 19:08:28 GMT
Github user kamrik commented on the pull request:

    https://github.com/apache/cordova-lib/pull/235#issuecomment-109401910
  
    Looks great! The need to duplicate common code like ConfgiParser in cordova-android is
a bit annoying and is bound to generate some versioning confusion. But probably it should
be dealt with later.
    
    One option could be to pass modules like ConfigParser to coraodva-android/Api.js from
code that requires Api.js (usually cordova-lib). It's weird and unintuitive, but would solve
the code duplication project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message