cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...
Date Thu, 04 Jun 2015 13:26:41 GMT
Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/144#discussion_r31719008
  
    --- Diff: bin/templates/scripts/cordova/lib/build.js ---
    @@ -87,6 +87,13 @@ module.exports.run = function (argv) {
             }
             return Q.nfcall(fs.writeFile, path.join(__dirname, '..', 'build-extras.xcconfig'),
extraConfig, 'utf-8');
         }).then(function () {
    +        // Ensure platform scripts are executable as the platform could be added on non-OSX
environment
    +        shell.find(projectPath).filter(function (file) {
    --- End diff --
    
    Makes sense; although there is another script there: 
    `ios/build/HelloCordova.build/Debug-iphonesimulator/HelloCordova.build/Script-304B58A110DAC018002A0835.sh`
    So we can probably check all folders except `www` - what do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message