Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F013B10A28 for ; Tue, 19 May 2015 18:57:04 +0000 (UTC) Received: (qmail 52673 invoked by uid 500); 19 May 2015 18:57:04 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 52634 invoked by uid 500); 19 May 2015 18:57:04 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 52622 invoked by uid 99); 19 May 2015 18:57:04 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 May 2015 18:57:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 02113C11BA for ; Tue, 19 May 2015 18:57:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.7 X-Spam-Level: X-Spam-Status: No, score=0.7 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, KAM_ASCII_DIVIDERS=0.8, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id qNNA9kRT0LoW for ; Tue, 19 May 2015 18:56:54 +0000 (UTC) Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com [209.85.216.181]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id 78CD122F28 for ; Tue, 19 May 2015 18:56:53 +0000 (UTC) Received: by qcblr10 with SMTP id lr10so11642577qcb.0 for ; Tue, 19 May 2015 11:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=gW6BfOOWxyyxznCP9C3Ue1S2SSZIvdVAGZcUGCr6gNw=; b=dwXifl72bTlzgHWQyIGo6r5sZ/mtxBdPc//U4z6Crb6WQM5ORqPdChViq2/Gwvh720 5csYTT4m25jvZp0ZWjhlZqVbqM1ArXaApFtUQYv0iMeUI3kAidJiXTnxmolvtN0NI0O5 nNsAFgGq6+o6QW4ML6u3KYfqJE+Z7wJKJrUgD9w4xsiiVWcllV7DBVLo2cR4c8Frrbpn z/P0HMvh6Pd8OWtNkB5lA0vFTmZtEFF05H7D1066ysXrHAvmt/jimD9e3XPsgk36V++m 0G8T48xdQy0khtSxZeTMJc+ZIP9es5CLtoxxpOd+gg9G4U4asRoTD+w+S9STbVkP/eBh 09UQ== MIME-Version: 1.0 X-Received: by 10.140.132.80 with SMTP id 77mr1100141qhe.36.1432061812529; Tue, 19 May 2015 11:56:52 -0700 (PDT) Received: by 10.96.10.1 with HTTP; Tue, 19 May 2015 11:56:52 -0700 (PDT) In-Reply-To: References: <67B15EFC-EC31-400A-9360-B0D7C69362CA@microsoft.com> Date: Tue, 19 May 2015 13:56:52 -0500 Message-ID: Subject: Re: Behavior of --copy-from From: Raymond Camden To: dev@cordova.apache.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Ok, so I filed a bug about it not copying misc files (https://issues.apache.org/jira/browse/CB-9041). I can understand wanting to skip platforms and plugins, but I think there are plenty of valid reasons to copy everything else. In my case, I built a hook for Visual Studio Code so I can do a build to the CLI. By storing this in a .settings folder, I expect --copy-from to copy it as well. As for it not making a valid Cordova project, I was not able to reproduce how I did that before. On Tue, May 19, 2015 at 11:09 AM, Michal Mocny wrote: > And for yet more context, I think this is because we did not want to impo= rt > plugins / platforms, and so did not just cp -R the whole thing, but perha= ps > thats a better strategy. > > Up to you now :) > > -Michal > > On Tue, May 19, 2015 at 12:07 PM, Michal Mocny wrot= e: > >> Just checked: >> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordov= a/create.js#L179 >> >> Seems config.xml isn't required. We import the nested www/ if it exists= , >> and same for config.xml merges and hooks. >> >> I would not expect any files/folders outside of www to be copied, dotfil= es >> or not. >> >> If this isn't desired behaviour, we need a feature request. >> >> On Tue, May 19, 2015 at 12:01 PM, Michal Mocny >> wrote: >> >>> The *intention* of copy-from / link-to is to import either (a) a web >>> project, or (b) another cordova project. >>> >>> We used to check for (b) I think by the existence of a config.xml and >>> www/ (note: double check config.xml is required). If that check passes= , we >>> copy those two nested contents only (I think) directly into the root of >>> your new project. >>> >>> If the check failed, we would copy the entire folder into the www/ of t= he >>> new project. >>> >>> There's some bug since you should get a valid cordova project no matter >>> what the contents of the import (with caveats of importing invalid >>> config.xml or bad apps). >>> >>> -Michal >>> >>> On Tue, May 19, 2015 at 7:12 AM, Raymond Camden >>> wrote: >>> >>>> I definitely can't recreate the "end up with a folder that isn't a >>>> project" but --copy-from does seem to ignore files it doesn't >>>> recognize. I filed a bug for it. >>>> >>>> On Tue, May 19, 2015 at 6:07 AM, Raymond Camden >>>> wrote: >>>> > No, what seems to happen to me is: >>>> > >>>> > If I copy-from a directory that has a www folder in it, then it is >>>> > treated as the *root* of the new project and a proper Cordova folder >>>> > is not created. >>>> > >>>> > If I copy-from a dir that does NOT have a www folder in it, it is >>>> > treated as the www folder of a new project. >>>> > >>>> > Nope, I lie. Ok, so this is weirder than I imagined. >>>> > >>>> > I made a new folder called "testwithwww". It has a file called >>>> > something.txt and a folder called www with an index.html. >>>> > >>>> > I sourced a new project with it. My www folder copied fine, but >>>> > something.txt was completely ignored. It did, however, make a proper >>>> > Cordova project. >>>> > >>>> > So this is a bit different from what I saw earlier where my first te= st >>>> > created something that wasn't a project, but it definitely failed to >>>> > copy a file over. >>>> > >>>> > >>>> > >>>> > >>>> > On Tue, May 19, 2015 at 2:18 AM, Dmitry Blotsky < >>>> dblotsky@microsoft.com> wrote: >>>> >> Hi Raymond, >>>> >> >>>> >> The semantics of =E2=80=9C--copy-from=E2=80=9D are: copy the passed= path in place of >>>> the new project's =E2=80=9Cwww=E2=80=9D directory, which =E2=80=9Ccord= ova create=E2=80=9D seems to obey. Is >>>> that not what happened in your case? However, the failure to copy over >>>> paths that start with =E2=80=9C.=E2=80=9D looks like a bug to me. Unle= ss someone says >>>> otherwise, feel totally free file a bug in JIRA. >>>> >> >>>> >> Kindly, >>>> >> Dmitry >>>> >> >>>> >> On May 17, 2015, at 7:56 AM, Raymond Camden >>> > wrote: >>>> >> >>>> >> Well shoot - as a follow up - if I make a new Cordova project, lets >>>> >> call it testsource2, and then copy .settings to it, and then follow= up >>>> >> by making a new project that uses copy-from pointing to testsource2= , >>>> >> the CLI isn't copying the .settings directory. That is a bug for su= re, >>>> >> right? >>>> >> >>>> >> On Sun, May 17, 2015 at 9:51 AM, Raymond Camden < >>>> raymondcamden@gmail.com> wrote: >>>> >> I thought I remember seeing a thread on this, but GMail is being a = bit >>>> >> cranky about how I search today. >>>> >> >>>> >> I had thought that if you used --copy-from and the directory you us= ed >>>> >> included www itself, then the folders would be copied over to a new >>>> >> project and merged in with normal default items. >>>> >> >>>> >> I just tested with a folder that had 2 items: A .settings directory >>>> >> and a www directory. While the CLI reported no issues, it did not >>>> >> create a proper Cordova project. It literally just copied .settings >>>> >> and www, but didn't do anything else to create a proper Cordova >>>> >> project. >>>> >> >>>> >> So I'm guessing that the expectation is that if you do not use a >>>> >> folder meant to be www, then your source directory should contain >>>> >> everything required for a proper Cordova project. But that's not >>>> >> forward-proof though. Imagine if Cordova 6 changes the project >>>> >> structure a bit so that a Foo folder is required, then I wouldn't b= e >>>> >> able to use my source dir w/o changing it. (Which, ok, probably won= 't >>>> >> happen.) >>>> >> >>>> >> So is this expected? Is this ok with others? Should I file a ER >>>> >> perhaps to make --copy-from in this situation add the rest of the >>>> >> project assets? >>>> >> >>>> >> -- >>>> >> >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D >>>> >> Raymond Camden, Developer Advocate for MobileFirst at IBM >>>> >> >>>> >> Email : raymondcamden@gmail.com >>>> >> Blog : www.raymondcamden.com >>>> >> Twitter: raymondcamden >>>> >> >>>> >> >>>> >> >>>> >> -- >>>> >> >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D >>>> >> Raymond Camden, Developer Advocate for MobileFirst at IBM >>>> >> >>>> >> Email : raymondcamden@gmail.com >>>> >> Blog : www.raymondcamden.com >>>> >> Twitter: raymondcamden >>>> >> >>>> >> -------------------------------------------------------------------= -- >>>> >> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org>>> dev-unsubscribe@cordova.apache.org> >>>> >> For additional commands, e-mail: dev-help@cordova.apache.org>>> dev-help@cordova.apache.org> >>>> >> >>>> > >>>> > >>>> > >>>> > -- >>>> > >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D >>>> > Raymond Camden, Developer Advocate for MobileFirst at IBM >>>> > >>>> > Email : raymondcamden@gmail.com >>>> > Blog : www.raymondcamden.com >>>> > Twitter: raymondcamden >>>> >>>> >>>> >>>> -- >>>> >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D >>>> Raymond Camden, Developer Advocate for MobileFirst at IBM >>>> >>>> Email : raymondcamden@gmail.com >>>> Blog : www.raymondcamden.com >>>> Twitter: raymondcamden >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org >>>> For additional commands, e-mail: dev-help@cordova.apache.org >>>> >>>> >>> >> --=20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Raymond Camden, Developer Advocate for MobileFirst at IBM Email : raymondcamden@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org