Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: Nikhil Khandelwal <nikhilkh@microsoft.com>
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Subject: RE: Cordova-js update
Thread-Topic: Cordova-js update
Thread-Index: AQHQkUuyQhe5GCyHZ0mae9xeA53ntp2HJDVw
Date: Fri, 22 May 2015 00:19:07 +0000
Message-ID: 
 <BLUPR03MB134585657924F46BE2DC95BC3C00@BLUPR03MB134.namprd03.prod.outlook.com>
References: 
 <CAMSbhBjUQo_CLBqTtT0AviqhGZr7ZXsjQW-PEuHqPuYxDhL9zQ@mail.gmail.com>
In-Reply-To: 
 <CAMSbhBjUQo_CLBqTtT0AviqhGZr7ZXsjQW-PEuHqPuYxDhL9zQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2015 00:19:07.0433
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB134

I'm new to this area. Steve: Can you provide some background on the motivat=
ion for this change? In particular, what is the advantage of this workflow,=
 over the existing one:

I have also made some changes to cordova-lib which will copy the contents o=
f cordova-js-src into platform_www when a project gets created. If a user d=
ecided to do cordova prepare --browserify, it will use the platform specifi=
c js files included in their app to build their cordova.js. [3] [4]

I think you need to update createmobilespec as it uses the grunt task to ge=
nerate the latest cordova.js for creating an app that is used by the Apache=
 CI (http://ci.cordova.io). Now the latest cordova.js is not being generate=
d and we are likely missing some test coverage as we make changes to cordov=
a.js.

Thanks,
Nikhil

-----Original Message-----
From: Steven Gill [mailto:stevengill97@gmail.com]=20
Sent: Monday, May 18, 2015 2:18 AM
To: dev@cordova.apache.org
Subject: Cordova-js update

I have a pull request [1] ready for cordova-js which adds platforms as dev =
dependencies and uses the previously moved cordova-js-src from the platform=
 repos instead of src/platform. I moved existing platform specific js into =
cordovajs/src/legacy-exec to use in cases where released platforms don't ha=
ve a cordova-js-src directory. [2]

I have updated both normal build and browserify build to use cordova-js-src=
 if present when building cordova.js.

I have also made some changes to cordova-lib which will copy the contents o=
f cordova-js-src into platform_www when a project gets created. If a user d=
ecided to do cordova prepare --browserify, it will use the platform specifi=
c js files included in their app to build their cordova.js. [3] [4]

I will need to make sure each platform has their most up to date platform s=
pecific js files in cordova-platform/cordova-js-src. After these PRs get me=
rged, platform maintainers should only worry about updating these files ins=
tead of what exists in cordovajs/src/legacy-exec.

Let me know if you have any questions or concerns.

[1] https://github.com/apache/cordova-js/pull/112
[2] https://issues.apache.org/jira/browse/CB-8441
[3] https://github.com/apache/cordova-lib/pull/221
[4] https://issues.apache.org/jira/browse/CB-8965

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org