Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: Nikhil Khandelwal <nikhilkh@microsoft.com>
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Subject: RE: Breaking changes in cordova-windows@>3.8.2
Thread-Topic: Breaking changes in cordova-windows@>3.8.2
Thread-Index: AdCPEtjJwLi0dmaFT4K1UCSiwjiSJQALFBeAAAj34fA=
Date: Fri, 15 May 2015 23:03:12 +0000
Message-ID: 
 <BLUPR03MB13408BC8A86CF36FF94F32EC3C70@BLUPR03MB134.namprd03.prod.outlook.com>
References: <d017c35d3eb04759b079b1f28f49ee95@HKNPR30MB0051.064d.mgd.msft.net>
 <CAMSbhBiZHq3dsu=7kMnJE4TNYeaq1SP2vAk6kQiOG41HpUQ6EA@mail.gmail.com>
In-Reply-To: 
 <CAMSbhBiZHq3dsu=7kMnJE4TNYeaq1SP2vAk6kQiOG41HpUQ6EA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2015 23:03:13.0191
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB134

The next version of cordova-windows will be 4.0.0 as it has Win10 support (=
which is a significant update) and this breaking change. Agreed, if there i=
s an engine tag that can make this more explicit - it would be perfect.

Thanks,
Nikhil


-----Original Message-----
From: Steven Gill [mailto:stevengill97@gmail.com]=20
Sent: Friday, May 15, 2015 11:44 AM
To: dev@cordova.apache.org
Subject: Re: Breaking changes in cordova-windows@>3.8.2

Can we set the engine tag so windows >3.8.2 (should be major jump to 4.0.0)=
 requires cordova-lib/cli >=3D5.1.0 (next version of tools should be a mino=
r
jump)

On Fri, May 15, 2015 at 9:59 AM, Vladimir Kotikov (Akvelon) < v-vlkoti@micr=
osoft.com> wrote:

> Hi List,
>
> I just want to let you know that we have pending PRs that will=20
> introduce braking changes in cordova-windows.
>
> These changes will move project update logic call from project build=20
> step to cordova-lib prepare step. The reason why we need this is that=20
> currently project update is triggered directly by build script (after 'af=
ter_prepare'
> hook being fired) and this makes plugin hooks and other tools working=20
> incorrectly (changes, made by hooks is being overwritten by this=20
> prepare logic).
>
> To be more precise, the following cases could be broken:
> 1. CLI > 5.0 (next version), Windows <=3D 3.8.2 (current or older) - the=
=20
> 'prepare' will be called twice (from lib and from platform's build) -=20
> unwanted, since changes that could be made by 'after_prepare' &=20
> 'before_compile' hooks will be overwritten by second 'prepare' call -=20
> but this is how it works now.
> 2. CLI <=3D 5.0 (current or older), Windows > 3.8.2 (next version) -=20
> 'prepare' will never be called, the platform code will never be=20
> updated - the worst case, the build probably will be broken.
>
> Some links:
> JIRA issue: https://issues.apache.org/jira/browse/CB-9025
> cordova-lib: https://github.com/apache/cordova-lib/pull/217
> cordova-windows: https://github.com/apache/cordova-windows/pull/77
>
> We're going to merge this soon, so if anyone has a strong opinion=20
> against these changes, please let us know.
>
> ---------------
> Best regards, Vladimir
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org