Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: omefire <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-228-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-228-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: CB-8627: Only update fetch.json
 when plu...
Content-Type: text/plain
Message-Id: <20150527183439.742EEDFFF0@git1-us-west.apache.org>
Date: Wed, 27 May 2015 18:34:39 +0000 (UTC)

Github user omefire commented on the pull request:

    https://github.com/apache/cordova-lib/pull/228#issuecomment-106026407
  
    This change makes sure that the fetch.json file only gets updated with plugin information once the plugin has been successfully installed. fetch.json is considered the source of truth with regards to what plugins are installed.
    
    One particular case this change addresses is that a case of missing variables during `cordova plugin add` (e.g: for plugins like facebook-plugin) will not end up with fetch.json modified even though the plugin addition failed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org