Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 89C8C189B5 for ; Wed, 27 May 2015 13:52:34 +0000 (UTC) Received: (qmail 59708 invoked by uid 500); 27 May 2015 13:52:34 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 59674 invoked by uid 500); 27 May 2015 13:52:34 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 59663 invoked by uid 99); 27 May 2015 13:52:34 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 May 2015 13:52:34 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id DFEF7DFDF1; Wed, 27 May 2015 13:52:33 +0000 (UTC) From: vladimir-kotikov To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-lib pull request: Draft implementation for Unified platfor... Content-Type: text/plain Message-Id: <20150527135233.DFEF7DFDF1@git1-us-west.apache.org> Date: Wed, 27 May 2015 13:52:33 +0000 (UTC) Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/226#discussion_r31134853 --- Diff: cordova-lib/src/cordova/metadata/PlatformHandler.js --- @@ -0,0 +1,100 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +*/ + +/* jshint sub:true */ + +'use strict'; + +var path = require('path'); +var shell = require('shelljs'); +var util = require('../util'); +var ParserHelper = require('./parserhelper/ParserHelper'); + +/** + * Base module for platform parsers + * + * @param {String} [platform] Platform name (e.g. android) + * @param {String} [projectPath] path/to/platform/project + */ +function PlatformHandler (platform, projectPath) { + + this.platform = platform || ''; + this.root = this.path = projectPath || ''; + + // Extend with a ParserHelper instance + Object.defineProperty(this, 'helper', { + value: new ParserHelper(this.platform), + enumerable: true, + configurable: false, + writable: false + }); +} + +/** + * Base implementation for getConfigXml. Assumes that config.xml + * is placed at the root of project. + * @return {String} Path to platform's config.xml file + */ +PlatformHandler.prototype.getConfigXml = function() { + return path.join(this.root, 'config.xml'); +}; + +/** + * Base implementation for getWwwDir. Assumes that + * www directory is placed at the root of project. + * @return {String} Path to platform's www directory. + */ +PlatformHandler.prototype.getWwwDir = function() { + return path.join(this.root, 'www'); +}; + +/** + * Base implementation for getCordovaJsSrc. Assumes that cordova.js + * source is placed at the root of platform's source dir. + * @return {String} Path to platform's 'cordova-js-src' folder. + */ +PlatformHandler.prototype.getCordovaJsSrc = function(platformSource) { + return path.resolve(platformSource, 'cordova-js-src'); +}; + +/** + * Base implementation for updateWww. + */ +PlatformHandler.prototype.updateWww = function() { + var projectRoot = util.isCordova(this.root); + var appWww = util.projectWww(projectRoot); + var platformWww = path.join(this.root, 'platform_www'); --- End diff -- Updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org