Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: dblotsky <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-78-cordova-coho@git.apache.org>
In-Reply-To: <git-pr-78-cordova-coho@git.apache.org>
Subject: [GitHub] cordova-coho pull request: Add command to merge PR
Content-Type: text/plain
Message-Id: <20150519081052.DF571E0525@git1-us-west.apache.org>
Date: Tue, 19 May 2015 08:10:52 +0000 (UTC)

Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-coho/pull/78#discussion_r30577315
  
    --- Diff: src/executil.js ---
    @@ -46,13 +47,16 @@ function execHelper(cmdAndArgs, silent, allowError) {
             gitCommitCount++;
         }
         cmdAndArgs[0] = cmdAndArgs[0].replace(/^git /, 'git -c color.ui=always ');
    -    if (!silent || silent === 3) {
    +    if (!silent || silent === 3 || pretend) {
             print('Executing:', cmdAndArgs.join(' '));
         }
    +    if(pretend) {
    +        return Q();
    +    }
    --- End diff --
    
    Isn't it expected that this function only gets called when `pretend` is false?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org