Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: dblotsky <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-53-cordova-medic@git.apache.org>
In-Reply-To: <git-pr-53-cordova-medic@git.apache.org>
Subject: [GitHub] cordova-medic pull request: CB-8936 Gathering logs for
 Android
Content-Type: text/plain
Message-Id: <20150508033243.A3A6AE442F@git1-us-west.apache.org>
Date: Fri,  8 May 2015 03:32:43 +0000 (UTC)

Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/53#discussion_r29915107
  
    --- Diff: medic/medic-log.js ---
    @@ -0,0 +1,60 @@
    +#!/usr/bin/env node
    +
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +/* jshint node: true */
    +
    +"use strict";
    +
    +var fs = require("fs");
    +
    +var shelljs  = require("shelljs");
    +var optimist = require("optimist");
    +var util     = require("../lib/util");
    +
    +// main
    +function main() {
    +
    +    // shell config
    +    shelljs.config.fatal  = false;
    +    shelljs.config.silent = false;
    +
    +    // command-specific args
    +    var argv = optimist
    +        .usage("Usage: $0 {platform}")
    +        .argv;
    +
    +    switch (argv.platform) {
    +        case util.ANDROID:
    +            var cmd = "adb logcat -d";
    +            console.log("executing " + cmd);
    +            shelljs.exec(cmd, function(code, output) {
    +                if (code > 0) {
    +                    fatal('Failed to run logcat command.');
    --- End diff --
    
    I was about to merge and did a test, and caught a small bug. It's now `util.fatal`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org