cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpolivy <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...
Date Thu, 28 May 2015 23:21:29 GMT
GitHub user dpolivy opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/49

    CB-9094: Smarter autohide logic on Android

    When the plugin is initialized, the splash screen is shown with an
    auto-hide delay. If a subsequent call to show() comes in while the
    splashscreen is visible, it will still be automatically hidden, even
    though the user expectation is that it wouldn't be.
    
    This fix tracks the "hideAfterDelay" setting of the most recent call to
    show() -- and when the auto hide timer goes off, if the most recent call
    to show() did not set hideAfterDelay, then the splashscreen will not be
    automatically hidden.
    
    This provides a more consistent -- and expected -- behavior based on
    user action.
    
    Fixes https://issues.apache.org/jira/browse/CB-9094

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dpolivy/cordova-plugin-splashscreen CB9094

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #49
    
----
commit c9165dbea3939388e12f96f03ca47b5a7724140d
Author: Dan Polivy <dan@cellartracker.com>
Date:   2015-05-28T23:20:21Z

    CB-9094: Smarter autohide logic on Android
    
    When the plugin is initialized, the splash screen is shown with an
    auto-hide delay. If a subsequent call to show() comes in while the
    splashscreen is visible, it will still be automatically hidden, even
    though the user expectation is that it wouldn't be.
    
    This fix tracks the "hideAfterDelay" setting of the most recent call to
    show() -- and when the auto hide timer goes off, if the most recent call
    to show() did not set hideAfterDelay, then the splashscreen will not be
    automatically hidden.
    
    This provides a more consistent -- and expected -- behavior based on
    user action.
    
    https://issues.apache.org/jira/browse/CB-9094

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message