cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: [DISCUSS] Dropping the -dev suffix
Date Wed, 13 May 2015 20:33:32 GMT
I think -dev is working fine and doing what it's supposed to do. The logic
of -label is subtle:

> var sem = require('semver')
undefined
> sem.satisfies('4.0.0-dev', '>=4.0.0')
false
> sem.satisfies('4.0.0-dev', '>=4.0')
true

So, the engine check should just to >=4.0, or >=4.0.0-dev

On Wed, May 13, 2015 at 1:39 PM, So, Byoungro <byoungro.so@intel.com> wrote:

> Sorry, I got the other way around. :)
> 4.0.0-dev is > 4.0.0.
>
> Byoungro So
> SSG / DPD / Mobile Computing and Compilers
> Intel Corporation
>
> -----Original Message-----
> From: So, Byoungro
> Sent: Wednesday, May 13, 2015 10:37 AM
> To: dev@cordova.apache.org
> Subject: RE: [DISCUSS] Dropping the -dev suffix
>
> Semver should be able to understand '4.0.0-dev' as the valid version
> string.
> There could be some other requirement problems, like <=, >.
> For example, 4.0.0-dev is < 4.0.0.
> So, if the requirement is >=4.0.0, then the version string '4.0.0-dev'
> will fail to satisfy the requirement.
>
> Byoungro So
> SSG / DPD / Mobile Computing and Compilers Intel Corporation
>
> -----Original Message-----
> From: Steven Gill [mailto:stevengill97@gmail.com]
> Sent: Wednesday, May 13, 2015 10:21 AM
> To: dev@cordova.apache.org
> Subject: [DISCUSS] Dropping the -dev suffix
>
> Recently, a issue (CB-9021) popped up where mobile spec was failing
> because the semver check failed on a platform due to `-dev` being in the
> version and not valid.
>
> I think we should remove -dev from our versions. Right now, after we do a
> release, we add -dev to show that the repo is in development and hasn't
> been released. I think we can accomplish the same by just bumping the
> version (minor?) in the package.json and just know it isn't released by
> seeing what is published on npm.
>
> Thoughts?
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message