cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...
Date Thu, 28 May 2015 13:59:55 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/48#discussion_r31235221
  
    --- Diff: src/android/SplashScreen.java ---
    @@ -91,7 +91,9 @@ protected void pluginInitialize() {
     
             firstShow = false;
             loadSpinner();
    -        showSplashScreen(true);
    +
    +        boolean hideAfterDelay = preferences.getBoolean("AutoHideSplashScreen", true);
    --- End diff --
    
    The AutoHide preference is meant to hide without the use of a timer (e.g. hide on first
paint after onload). Would be happy to accept a PR for this, but I don't think we should have
a PR that just turns it off. For this, set a very large timeout.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message