cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: CB-8954 Adds support for `requirements` ...
Date Tue, 26 May 2015 18:59:56 GMT
Github user TimBarham commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/142#discussion_r31067511
  
    --- Diff: bin/lib/check_reqs.js ---
    @@ -75,20 +78,74 @@ module.exports.help = function () {
      * @return {Promise}           Returns a promise either resolved with tool version or
rejected
      */
     function checkTool (tool, minVersion, optMessage) {
    -    if (os.platform() !== 'darwin'){
    -        // Build iOS apps available for OSX platform only, so we reject on others platforms
    -        return Q.reject('Cordova tooling for iOS requires Apple OS X');
    -    }
         // Check whether tool command is available at all
         var tool_command = shell.which(tool);
         if (!tool_command) {
    -        return Q.reject(optMessage || (tool + 'command is unavailable.'));
    +        return Q.reject(tool + ' was not found. ' + (optMessage || ''));
    --- End diff --
    
    I presume the `opt` in `optMessage` stands for 'optional` - it's not longer really optional,
so perhaps change the name?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message