cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kamrik <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: Draft implementation for Unified platfor...
Date Tue, 26 May 2015 15:47:37 GMT
Github user kamrik commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/226#discussion_r31048534
  
    --- Diff: cordova-lib/src/cordova/metadata/PlatformHandler.js ---
    @@ -0,0 +1,100 @@
    +/**
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +*/
    +
    +/* jshint sub:true */
    +
    +'use strict';
    +
    +var path = require('path');
    +var shell = require('shelljs');
    +var util = require('../util');
    +var ParserHelper = require('./parserhelper/ParserHelper');
    +
    +/**
    + * Base module for platform parsers
    + *
    + * @param {String} [platform]    Platform name (e.g. android)
    + * @param {String} [projectPath] path/to/platform/project
    + */
    +function PlatformHandler (platform, projectPath) {
    +
    +    this.platform = platform || '';
    +    this.root = this.path = projectPath || '';
    +
    +    // Extend with a ParserHelper instance
    +    Object.defineProperty(this, 'helper', {
    +        value: new ParserHelper(this.platform),
    +        enumerable: true,
    +        configurable: false,
    +        writable: false
    --- End diff --
    
    The writeable/configurable:false, has the tendency to interfere with jasmine spies which
causes our tests to fail with very obscure error messages. Just in case you encounter such
errors, otherwise I'm all for leaving this as false. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message