cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-mobile-spec pull request: CB-8843 Fixed mobilespec tests t...
Date Fri, 22 May 2015 07:26:58 GMT
Github user alsorokin commented on a diff in the pull request:

    https://github.com/apache/cordova-mobile-spec/pull/130#discussion_r30874137
  
    --- Diff: cordova-plugin-mobilespec-tests/tests/whitelist.tests.js ---
    @@ -202,7 +202,7 @@ exports.defineAutoTests = function () {
                 itShouldReject('http://www.apache.org.evil.com/');
                 itShouldAccept('file:///foo');
                 if (cordova.platformId == 'android')
    -                itShouldAccept('content:///foo');
    +                itShouldReject('content:///foo');
    --- End diff --
    
    It has been changed in https://github.com/apache/cordova-mobile-spec/commit/b8401eb3c99573de6e6ae6af952f32d19bd2cd28#diff-e3ccd521f7df2ab57e6ee9133e737b36R205
    I have asked the author of this change if this is intentional but received no reply.
    I suppose that it was not intentional so I am reverting that change here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message