cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From muratsu <>
Subject [GitHub] cordova-plugin-camera pull request: [windows] major refactor : rea...
Date Wed, 20 May 2015 22:44:50 GMT
Github user muratsu commented on a diff in the pull request:
    --- Diff: src/windows/CameraProxy.js ---
    @@ -111,8 +127,8 @@ function resizeImage(successCallback, errorCallback, file, targetWidth,
     // Because of asynchronous method, so let the successCallback be called in it.
     function resizeImageBase64(successCallback, errorCallback, file, targetWidth, targetHeight)
    -    Windows.Storage.FileIO.readBufferAsync(file).done( function(buffer) {
    -        var strBase64 = Windows.Security.Cryptography.CryptographicBuffer.encodeToBase64String(buffer);
    +    fileIO.readBufferAsync(file).done( function(buffer) {
    +        var strBase64 =encodeToBase64String(buffer);
    --- End diff --
    nitpick: no space after =

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message