cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-coho pull request: Add command to merge PR
Date Wed, 20 May 2015 15:50:44 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-coho/pull/78#discussion_r30717099
  
    --- Diff: src/executil.js ---
    @@ -52,7 +52,7 @@ function execHelper(cmdAndArgs, silent, allowError) {
         var result = superspawn.spawn(cmdAndArgs[0], cmdAndArgs.slice(1), {stdio: (silent
&& (silent !== 2)) ? 'default' : 'inherit'});
         return result.then(null, function(e) {
             if (allowError) {
    -            return null;
    +            throw e;
    --- End diff --
    
    This is much nicer :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message