cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-js pull request: CB-8996 (Windows) Fixed invalid null comp...
Date Tue, 12 May 2015 21:26:24 GMT
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-js/pull/110#issuecomment-101426677
  
    Looks good!
    
    @purplecabbage
    risingj.com
    
    On Tue, May 12, 2015 at 2:18 PM, Dmitry Blotsky <notifications@github.com>
    wrote:
    
    > Merged, making it check explicitly for undefined and null, as per Jesse's
    > note that 0 is a valid return value, and if(condition) wasn't sufficient.
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cordova-js/pull/110#issuecomment-101424430>.
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message