cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-docs pull request: Document iOS specific callback for orie...
Date Fri, 08 May 2015 02:19:41 GMT
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-docs/pull/276#issuecomment-100076514
  
    I'm not in favour of adding yet another preference. 
    
    If we look at the Apple docs: 
    https://developer.apple.com/library/ios/documentation/General/Reference/InfoPlistKeyReference/Articles/iPhoneOSKeys.html#//apple_ref/doc/uid/TP40009252-SW10
    
    Setting no values, implicitly sets the orientation to Portrait. Thus "default" === "portrait"
here. I'm not sure this is really useful for users, especially if they don't know what "default"
is (but that's a matter of documentation). Of course this varies by platform.
    
    I would leave default as implemented by @mmrko -- since it is technically correct -- but
add a new preference "all" which is unambiguously clear.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message