cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brodybits <...@git.apache.org>
Subject [GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
Date Thu, 07 May 2015 17:17:33 GMT
Github user brodybits commented on the pull request:

    https://github.com/apache/cordova-wp8/pull/79#issuecomment-99942506
  
    Array.ConvertAll did not compile on Visual Studio Express 2013, and is apparently not
supported for Metro or Silverlight. Figured out how to do this using Linq:
    
    ```diff
    diff --git a/src/wp/File.cs b/src/wp/File.cs
    index 941c9c8..085ef77 100644
    --- a/src/wp/File.cs
    +++ b/src/wp/File.cs
    @@ -13,6 +13,7 @@
     */
     
     using System;
    +using System.Linq;
     using System.Collections.Generic;
     using System.Diagnostics;
     using System.IO;
    @@ -695,7 +696,9 @@ public void readAsArrayBuffer(string options)
                         buffer = readFileBytes(filePath, startPos, endPos, isoFile);
                     }
     
    -                DispatchCommandResult(new PluginResult(PluginResult.Status.OK, buffer),
callbackId);
    +                int[] bufferAsIntArray = (from b in buffer select (int)b).ToArray();
    +
    +                DispatchCommandResult(new PluginResult(PluginResult.Status.OK, bufferAsIntArray),
callbackId);
                 }
                 catch (Exception ex)
                 {
    ```
    
    Please let me know if you want me to issue a PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message