cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-8946: Added the "WindowsToastCapa...
Date Tue, 05 May 2015 18:03:21 GMT
Github user robpaveza commented on the pull request:

    https://github.com/apache/cordova-windows/pull/74#issuecomment-99160167
  
    The plugin is likely unable to do this directly except via hooks, because the `<config-file>`
directive is an element-level change, but the modification is at an attribute-level (Application/VisualElements@ToastCapable)
    
    We have several preferences that modify the attributes of the VisualElements tag.  Plugins
can specify elements become descendants of other elements in package.appxmanifest, but AFAIK
they can't say "there's an existing element, set this attribute of that element" and have
it respected by plugman.
    
    Making such a change to plugman seems much larger and more invasive than creating a preference
like this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message