cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-medic pull request: added Firefox OS
Date Fri, 01 May 2015 19:53:36 GMT
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/49#discussion_r29528708
  
    --- Diff: medic/medic-run.js ---
    @@ -333,6 +333,25 @@ function main() {
         var buildCommand = cli + " build " + platform + " -- " + platformArgs;
         var runCommand   = cli + " run " + platform + " -- " + platformArgs;
     
    +    if(platform === util.FIREFOXOS) {
    +
    +        var runServe = cli + " serve";
    +
    +        // run the code
    +        // NOTE:
    +        //      this is ASYNCHRONOUS
    +        util.medicLog("running:");
    +        util.medicLog("    " + runServe);
    +        shelljs.exec(runServe, {silent: false, async: true}, function (returnCode, output)
{
    +            if (returnCode != 0 || CORDOVA_ERROR_PATTERN.test(output)) {
    +                util.fatal("run failed");
    +            } else {
    +                window.open("http://localhost:8000/firefoxos/www/");
    --- End diff --
    
    This script is run from node, which does not have the `window` object. To open the app
you will need to launch a real browser via command line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message