cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Barham <Tim.Bar...@microsoft.com>
Subject Re: Cordova 5.0.0 "duplicate cordova" check breaks Ripple
Date Mon, 04 May 2015 22:56:25 GMT
Hey Jesse - is your reasoning behind that to avoid having to release an update for Cordova
tools + all platforms, or because you don't want to change the existing Cordova logic (and
if the latter, what's your concern)?

Have you had any inspiration about how to fix Ripple to avoid tripping this? I've not been
able to come up with a safe approach yet. On the other hand, the change in Cordova to avoid
triggering this is very simple - just a pain that it requires releasing a bunch of updates.

Tim
________________________________________
From: Jesse <purplecabbage@gmail.com>
Sent: Saturday, May 2, 2015 2:28 AM
To: dev@cordova.apache.org
Subject: Re: Cordova 5.0.0 "duplicate cordova" check breaks Ripple

I think ripple will need to change, I'll have a look and see if there is a more elegant way
to implement honeypot.



> On Apr 30, 2015, at 7:06 PM, Tim Barham <Tim.Barham@microsoft.com> wrote:
>
> Hey everyone - a bug was filed today against Ripple that it is broken with
> Cordova 5.0.0. The issue is that Ripple triggers the new "duplicate
> cordova" check:
>
>     cordova-js/src/cordova.js line 22:
>     if ("cordova" in window) { throw new Error("cordova already defined"); };
>
> Ripple patches cordova by defining a setter for window.cordova to
> intercept it being created. This is sufficient to make ("cordova" in
> window) return true. I don't see a way to readily resolve this issue in
> Ripple. We can fix it in Cordova by changing the test to:
>
>   if (window.cordova) ...
>
> Couple of questions:
> 1. Any reason not to make this change?
> 2. To get this fix out will require re-releasing all platforms, correct?
> And I presume a tools release to update the pinned platforms? Is this
> sufficient reason to trigger such a release?
>
> Thanks!
>
> Tim

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message