Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DFF0E176D7 for ; Tue, 28 Apr 2015 19:28:09 +0000 (UTC) Received: (qmail 74589 invoked by uid 500); 28 Apr 2015 19:28:09 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 74550 invoked by uid 500); 28 Apr 2015 19:28:09 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 74507 invoked by uid 99); 28 Apr 2015 19:28:09 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Apr 2015 19:28:09 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 317BDE08DB; Tue, 28 Apr 2015 19:28:09 +0000 (UTC) From: robpaveza To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org Message-ID: Subject: [GitHub] cordova-plugin-device-motion pull request: CB-8926: The tests modu... Content-Type: text/plain Date: Tue, 28 Apr 2015 19:28:09 +0000 (UTC) GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/29 CB-8926: The tests module tries to access an undefined global The tests module tries to access an undefined global 'Accelerometer' on fail callbacks. This results in another JS error, "ReferenceError: 'Accelerometer' is undefined." This change passes through the error message instead of attempting to index into the undefined global. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-device-motion CB-8926 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device-motion/pull/29.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #29 ---- commit 6f8e92ee3b71c6489563d3fd2ab2e4da5636bf85 Author: Rob Paveza Date: 2015-04-28T19:25:54Z CB-8926: The tests module tries to access an undefined global 'Accelerometer' on fail callbacks. This results in another JS error, "ReferenceError: 'Accelerometer' is undefined." This change passes through the error message instead of attempting to index into it. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org