Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: sinofool <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-162-cordova-android@git.apache.org>
In-Reply-To: <git-pr-162-cordova-android@git.apache.org>
Subject: [GitHub] cordova-android pull request: CB-3360 Set custom User-Agent
Content-Type: text/plain
Message-Id: <20150402204248.98D51E2F4C@git1-us-west.apache.org>
Date: Thu,  2 Apr 2015 20:42:48 +0000 (UTC)

Github user sinofool commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/162#discussion_r27695146
  
    --- Diff: framework/src/org/apache/cordova/engine/SystemWebViewEngine.java ---
    @@ -199,7 +199,19 @@ private void initWebViewSettings() {
             
             // Fix for CB-1405
             // Google issue 4641
    -        settings.getUserAgentString();
    +        String defaultUserAgent = settings.getUserAgentString();
    +
    +        // Fix for CB-3360
    +        String overrideUserAgent = getCordovaWebView().getPreferences().getString("OverrideUserAgent", null);
    --- End diff --
    
    @agrieve Yes, thanks for the great suggestion, I will change it this weekend.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org