Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: nikhilkh <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-164-cordova-android@git.apache.org>
In-Reply-To: <git-pr-164-cordova-android@git.apache.org>
Subject: [GitHub] cordova-android pull request: CB-8484: Adds support creating
 signe...
Content-Type: text/plain
Message-Id: <20150401170338.D5627E05DF@git1-us-west.apache.org>
Date: Wed,  1 Apr 2015 17:03:38 +0000 (UTC)

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/164#discussion_r27588457
  
    --- Diff: bin/templates/cordova/lib/build.js ---
    @@ -402,6 +440,16 @@ function parseOpts(options, resolvedTarget) {
                     case 'gradleArg':
                         ret.extraArgs.push(flagValue);
                         break;
    +                case 'keystore':
    +                case 'alias':
    +                case 'keytorePassword':
    +                case 'password':
    +                case 'keystoreType':
    +                    packageArgs[flagName] = flagValue;
    +                    break;
    +                case 'buildConfig':
    +                    buildConfig = flagValue.replace(/"/g, '');
    --- End diff --
    
    That's true only when the argument is specified separately e.g. build --buildConfig "foo bar\build.json" - the shell will remove the quotes. But not for a scenario like --buildConfig="foo bar\build.json"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org