Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DC3EF17B8F for ; Wed, 1 Apr 2015 00:29:47 +0000 (UTC) Received: (qmail 39370 invoked by uid 500); 1 Apr 2015 00:29:44 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 39326 invoked by uid 500); 1 Apr 2015 00:29:44 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 39315 invoked by uid 99); 1 Apr 2015 00:29:44 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Apr 2015 00:29:44 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4431BE1805; Wed, 1 Apr 2015 00:29:44 +0000 (UTC) From: agrieve To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-android pull request: CB-8484: Adds support creating signe... Content-Type: text/plain Message-Id: <20150401002944.4431BE1805@git1-us-west.apache.org> Date: Wed, 1 Apr 2015 00:29:44 +0000 (UTC) Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/164#discussion_r27536261 --- Diff: bin/templates/cordova/lib/build.js --- @@ -402,6 +440,16 @@ function parseOpts(options, resolvedTarget) { case 'gradleArg': ret.extraArgs.push(flagValue); break; + case 'keystore': + case 'alias': + case 'keytorePassword': + case 'password': + case 'keystoreType': + packageArgs[flagName] = flagValue; + break; + case 'buildConfig': + buildConfig = flagValue.replace(/"/g, ''); --- End diff -- Quotes for these reasons are generally interpreted by the shell (cmd.exe), and when we see it here, they should be gone already (and flagValue will have a space in it). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org