cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From akinzie <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-8253 Fix potential unreleas...
Date Mon, 27 Apr 2015 15:40:00 GMT
GitHub user akinzie opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/90

    CB-8253 Fix potential unreleased resources

    There was a place (~line 701) in CameraLauncher.java where there was the
    potential for input and output streams to never be closed if an exception
    occurs at the wrong time.   There were some other places where an
    InputStream was used anonymously, and so would never be closed.
    
    This change introduces try/finally blocks to ensure that the streams will
    always end up closed.
    
    This is the same as the pull request https://github.com/apache/cordova-plugin-camera/pull/67
except that my change is applied to the updated repo.
    
    Change-Id: I479bceddcd631bfec45c3f5ee7e88ddb04c59073

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akinzie/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/90.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #90
    
----
commit ec6d29de50e1e8550ddbef66f4214a2720de9cc2
Author: Alan Kinzie <alan.kinzie@sap.com>
Date:   2015-01-07T18:59:22Z

    CB-8253 Fix potential unreleased resources
    
    There was a place (~line 701) in CameraLauncher.java where there was the
    potential for input and output streams to never be closed if an exception
    occurs at the wrong time.   There were some other places where an
    InputStream was used anonymously, and so would never be closed.
    
    This change introduces try/finally blocks to ensure that the streams will
    always end up closed.
    
    Change-Id: I479bceddcd631bfec45c3f5ee7e88ddb04c59073

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message