cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robpaveza <...@git.apache.org>
Subject [GitHub] cordova-plugin-device-motion pull request: CB-8926: The tests modu...
Date Tue, 28 Apr 2015 19:28:09 GMT
GitHub user robpaveza opened a pull request:

    https://github.com/apache/cordova-plugin-device-motion/pull/29

    CB-8926: The tests module tries to access an undefined global

    The tests module tries to access an undefined global 'Accelerometer' on fail callbacks.
 This results in another JS error, "ReferenceError: 'Accelerometer' is undefined."  This change
passes through the error message instead of attempting to index into the undefined global.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-device-motion CB-8926

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-device-motion/pull/29.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #29
    
----
commit 6f8e92ee3b71c6489563d3fd2ab2e4da5636bf85
Author: Rob Paveza <rob.paveza@microsoft.com>
Date:   2015-04-28T19:25:54Z

    CB-8926: The tests module tries to access an undefined global
    'Accelerometer' on fail callbacks.  This results in another JS error,
    "ReferenceError: 'Accelerometer' is undefined."  This change passes
    through the error message instead of attempting to index into it.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message