cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rachel-carvalho <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: Orientation preference now updates value...
Date Mon, 13 Apr 2015 18:37:54 GMT
GitHub user rachel-carvalho opened a pull request:

    https://github.com/apache/cordova-lib/pull/207

    Orientation preference now updates value for iPad

    As dicussed in #128 (more specifically https://github.com/apache/cordova-lib/pull/128#issuecomment-89316079),
currently setting this:
    ```xml
    <preference name="Orientation" value="landscape"/>
    ```
    doesn't affect the iPad.
    
    So I added code and specs for updating `UISupportedInterfaceOrientations~ipad`, as well
as `UISupportedInterfaceOrientations`.
    
    This is my first time contributing to Cordova, sorry if something is missing! All input
is welcome :)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rachel-carvalho/cordova-lib pref-orientation-ipad

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/207.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #207
    
----
commit 6f0b9a4c1433c745218c529d6d2deedce5624925
Author: Rachel Carvalho <rachel.carvalho@gmail.com>
Date:   2015-04-13T18:27:15Z

    Orientation preference now updates `UISupportedInterfaceOrientations~ipad` too
    (as discussed in Github #128)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message