cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tony-- <...@git.apache.org>
Subject [GitHub] cordova-android pull request: fix CB-8684 - support onStart/onStop...
Date Wed, 08 Apr 2015 19:03:16 GMT
GitHub user tony-- opened a pull request:

    https://github.com/apache/cordova-android/pull/173

    fix CB-8684 - support onStart/onStop lifecycle events in plugins for Android

    A couple notes about this PR.
    1. I feel pretty sure that CordovaActivity.shouldHandleStartOnAppViewInit is needed in
order to reliably get an onStart event to interested plugins, but not sure about CordovaWebViewImpl.shouldCallOnStartDuringInit.
 Don't want to add cruft, but would like these events to be reliable.
    2. I tried to add a reasonable test for this new feature, but I feel like there might
be a more elegant approach?  I'm open to feedback and willing to modify the approach.  Also
(per @agrieve suggestion), I set onload=true, but it seemed to be working without it (which
seems a little weird, but I didn't want to delay this PR any further - will step through it
later).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tony--/cordova-android CB-8684-clean-for-PR

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #173
    
----
commit 683965c6e7759030352e8e45252ca6aa8b13bf1a
Author: Tony Homer <tony.homer@intel.com>
Date:   2015-04-08T19:00:38Z

    CB-8684 support onStart/onStop lifecycle events in plugins for Android

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message