cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From herrevilkitten <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: CB-8467 provide hide met...
Date Sat, 04 Apr 2015 02:21:54 GMT
GitHub user herrevilkitten opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/101

    CB-8467 provide hide method to hide browser window

    Added support for hiding the web view container.  This maintains the browser
    session without closing it.  The browser window can be repeatedly hidden and
    shown.
    
    ** This has only been tested on android and ios **
    
    amazon/android:
    An additional `hide` action was added to `InAppBrowser#execute`.  It is
    identical to `show`, except that it calls `dialog.hide()` instead.
    
    blackberry10:
    no changes
    
    firefoxos:
    Added a `hide` method that is identical to `show`, indicating it is not
    supported.
    
    ios:
    Added a `hide` method that is identical to `show`, except that it uses
    `dismissViewControllerAnimated`.  It checks the value of
    `_previousStatusBarStyle`.  If it is `-1`, the method returns with no
    action performed.  If it is not, it is set to `-1.`
    
    ubuntu:
    Added a `hide` method that sets `CordovaWrapper.global.inappbrowser.visible` to
    `false`.
    
    windows:
    Added a `hide` method that sets `browserWrap.style.display` to `none`.
    
    wp:
    Added a `hide` method that is identical to `show`, except that it sets
    `browser.Visibility` to `Visibility.Collapsed` and sets `AppBar.IsVisible` to
    `false`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/herrevilkitten/cordova-plugin-inappbrowser CB-8467_provide_hide_method_to_hide_browser_window

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #101
    
----
commit 573b1bdc777370a8af860a5b6044e8ddb3f69932
Author: ekidder3 <eric.kidder@gtri.gatech.edu>
Date:   2015-02-05T12:20:57Z

    CB-8467
    
    Added support for hiding the web view container.  This maintains the browser
    session without closing it.  The browser window can be repeatedly hidden and
    shown.
    
    ** This has only been tested on android and ios **
    
    amazon/android:
    An additional `hide` action was added to `InAppBrowser#execute`.  It is
    identical to `show`, except that it calls `dialog.hide()` instead.
    
    blackberry10:
    no changes
    
    firefoxos:
    Added a `hide` method that is identical to `show`, indicating it is not
    supported.
    
    ios:
    Added a `hide` method that is identical to `show`, except that it uses
    `dismissViewControllerAnimated`.  It checks the value of
    `_previousStatusBarStyle`.  If it is `-1`, the method returns with no
    action performed.  If it is not, it is set to `-1.`
    
    ubuntu:
    Added a `hide` method that sets `CordovaWrapper.global.inappbrowser.visible` to
    `false`.
    
    windows:
    Added a `hide` method that sets `browserWrap.style.display` to `none`.
    
    wp:
    Added a `hide` method that is identical to `show`, except that it sets
    `browser.Visibility` to `Visibility.Collapsed` and sets `AppBar.IsVisible` to
    `false`.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message