cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Willy Aguirre <marti1...@gmail.com>
Subject Re: firefoxos to cordova-medic
Date Wed, 01 Apr 2015 15:44:54 GMT
Hi Dmitry,

there are two plugins firefoxos does not has support
media and mediacapture

finally:

λ node build_firefoxos.js
G:\cordova-medic\.git G:\cordova-medic
G:\cordova-medic
G:\cordova-medic\bin G:\cordova-medic
G:\cordova-medic
G:\cordova-medic\buildbot-conf G:\cordova-medic
G:\cordova-medic
G:\cordova-medic\mobilespec G:\cordova-medic
G:\cordova-medic
G:\cordova-medic\node_modules G:\cordova-medic
G:\cordova-medic
G:\cordova-medic\runner G:\cordova-medic
G:\cordova-medic
G:\cordova-medic\src G:\cordova-medic
G:\cordova-medic
Writing medic.json to G:\cordova-medic\mobilespec\www

anything else for close this PR

Regards,

Willy




2015-03-23 20:27 GMT-05:00 Dmitry Blotsky <dblotsky@microsoft.com>:

> Hi Willy,
>
> Thanks for the PR! I've made some comments on GitHub.
>
> What you're referring to regarding plugins is actually a bit of a misnomer
> on our side! The variables "cordova_plugins_all" and
> "cordova_plugins_windows" are lists of steps for all platforms, and for
> Windows, respectively. Those are not lists of plugins to install. Perhaps
> they should be renamed to something like "cordova_plugins_steps_general"
> and "cordova_plugins_steps_windows" in the future.
>
> The build uses cordova-mobile-spec to install plugins, and
> cordova-mobile-spec installs all the core plugins by default. When you say
> that some plugins are unsupported for firefoxos, do you mean that they have
> no code for firefoxos, or that they crash on firefoxos? If they crash, then
> it may be worth it to fix them so that they at least gracefully degrade,
> but still get installed successfully.
>
> Kindly,
> Dmitry
>
> -----Original Message-----
> From: Willy Aguirre [mailto:marti1125@gmail.com]
> Sent: Monday, March 23, 2015 2:07 PM
> To: dev@cordova.apache.org
> Subject: Re: firefoxos to cordova-medic
>
> I send my pr. for example in factory=cordova_plugins_windows I think we
> need something similar to *factory=cordova_plugins_windows* for firefoxos
> because it doesn't support all plugins
>
> Regards,
>
> Willy
>
> 2015-03-23 14:29 GMT-05:00 Willy Aguirre <marti1125@gmail.com>:
>
> > thanks!,  I opened an issue
> > https://issues.apache.org/jira/browse/CB-8734
> >
> > 2015-03-23 13:30 GMT-05:00 Dmitry Blotsky <dblotsky@microsoft.com>:
> >
> > Hi Willy,
> >>
> >> Thank you for contributing support for firefoxos to medic! It appears
> >> that you have an older version of medic: there have been some changes
> >> to medic that are incompatible with the old version. Specifically, in
> >> the new medic code you will only need to change the following files
> >> around the highlighted lines:
> >>
> >>
> >> https://github.com/apache/cordova-medic/blob/master/buildbot-conf/cor
> >> dova.conf#L297
> >>
> >> https://github.com/apache/cordova-medic/blob/master/buildbot-conf/cor
> >> dova-repos.json#L169
> >>
> >> Then, you will need to add the following two files you've created:
> >>
> >> https://github.com/marti1125/cordova-medic/blob/master/build_firefoxo
> >> s.js
> >>
> >> https://github.com/marti1125/cordova-medic/blob/master/src/build/make
> >> rs/firefoxos.js
> >>
> >> To make your changes available to us for review and eventual
> >> acceptance into the master branch, you will need make a fork of the
> >> medic repo and create a Pull Request (PR). Instructions on how to do
> >> this in general are
> >> here: https://help.github.com/articles/using-pull-requests/, and
> >> instructions specific to contributing to Apache Cordova are here:
> >> http://wiki.apache.org/cordova/IssueWorkflow#Git_Workflow.
> >>
> >> Looking forward to your PR!
> >>
> >> Kindly,
> >> Dmitry
> >>
> >> -----Original Message-----
> >> From: Willy Aguirre [mailto:marti1125@gmail.com]
> >> Sent: Monday, March 23, 2015 10:23 AM
> >> To: dev@cordova.apache.org
> >> Subject: firefoxos to cordova-medic
> >>
> >> Hi!
> >>
> >> I am working in add support for firefoxos to cordova-medic. I really
> >> appreciate if you can give me some instructions or tips to finish my
> >> homework ^_^
> >>
> >> I make this file
> >> https://github.com/marti1125/cordova-medic/blob/master/build_firefoxo
> >> s.js quite similar to other's but I have some restrictions because
> >> firefoxos doesn't support all plugins.
> >>
> >> in the new version it has
> >>
> >> https://github.com/apache/cordova-medic/blob/master/buildbot-conf/cor
> >> dova-config.json.sample
> >>
> >> but I have this
> >>
> >> https://github.com/marti1125/cordova-medic-firefoxos/blob/master/cord
> >> ova-config.json#L18
> >>
> >> I added these lines
> >>
> >> https://github.com/marti1125/cordova-medic/blob/master/cordova-repos.
> >> json#L91
> >>
> >> in cordova.conf
> >> https://github.com/marti1125/cordova-medic/blob/master/cordova.conf#L
> >> 332
> >>
> >> and finally
> >>
> >> https://github.com/marti1125/cordova-medic/blob/master/src/build/make
> >> rs/firefoxos.js but it doesn't work very well because I got this
> >> error  #L16 <
> >> https://github.com/marti1125/cordova-medic/blob/master/src/build/make
> >> rs/firefoxos.js#L16
> >> >
> >>
> >> Thanks,
> >>
> >> Willy
> >>
> >> --
> >> Willy Aguirre | @willrre
> >> Blog: http://osgux.tumblr.com/
> >> Mozilla Rep: https://reps.mozilla.org/u/Willy/ Mozilla Hispano -
> >> Willyaguirre <
> >> https://www.mozilla-hispano.org/documentacion/Usuario:Willyaguirre>
> >>
> >
> >
> >
> > --
> > Willy Aguirre | @willrre
> > Blog: http://osgux.tumblr.com/
> > Mozilla Rep: https://reps.mozilla.org/u/Willy/ Mozilla Hispano -
> > Willyaguirre
> > <https://www.mozilla-hispano.org/documentacion/Usuario:Willyaguirre>
> >
>
>
>
> --
> Willy Aguirre | @willrre
> Blog: http://osgux.tumblr.com/
> Mozilla Rep: https://reps.mozilla.org/u/Willy/ Mozilla Hispano -
> Willyaguirre <
> https://www.mozilla-hispano.org/documentacion/Usuario:Willyaguirre>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>



-- 
Willy Aguirre | @willrre
Blog: http://osgux.tumblr.com/
Mozilla Rep: https://reps.mozilla.org/u/Willy/
Mozilla Hispano - Willyaguirre
<https://www.mozilla-hispano.org/documentacion/Usuario:Willyaguirre>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message